refactor: reorder logic

medikoo · Jul 10, 2019 · 3e905c1 · 3e905c1
1 parent a24b31c
commit 3e905c1
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/lib/private/setup-dependency/install-external/prepare/index.js b/lib/private/setup-dependency/install-external/prepare/index.js
@@ -38,14 +38,13 @@ module.exports = memoizee(
 			recursive: true,
 			force: true
 		});
-		if (versionCachePath) {
-			await rename(packageTmpDir, versionCachePath, { intermediate: true });
-			const packageJson = getPackageJson(versionCachePath) || {};
-			packageJson._npmCrossLinkCacheName = versionCacheName;
-			await updatePackageJson(versionCachePath, packageJson);
-			return versionCachePath;
-		}
-		return packageTmpDir;
+		if (!versionCachePath) return packageTmpDir;
+
+		await rename(packageTmpDir, versionCachePath, { intermediate: true });
+		const packageJson = getPackageJson(versionCachePath) || {};
+		packageJson._npmCrossLinkCacheName = versionCacheName;
+		await updatePackageJson(versionCachePath, packageJson);
+		return versionCachePath;
 	},
 	{ promise: true, length: 2 }
 );