Install vcredist by default to solve ORT issues #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
what about the app? i don't think we have many windows cli users |
@louis030195 any idea as to how to install vcredist when the app is installed? We could bundle it maybe |
|
how big is that? @Neptune650 i guess we can bundle second option is to download at runtime (more risky) |
@louis030195 it's about 12mb, is that okay for bundling? |
|
yeah |
@louis030195 Updated to bundle it |
|
/approve |
|
@louis030195: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment. |
|
nice :) |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #1034
/closes #1034
@louis030195 Other people have reported installing vcredist fixes it microsoft/onnxruntime#11230 (comment), doesn't seem to happen anymore after.
Uses a PowerShell Gallery module to install it silently.