fix up optional.equals check

mebigfatguy · Oct 22, 2021 · b194c6b · b194c6b
1 parent db220ba
commit b194c6b
Show file tree

Hide file tree

Showing 2 changed files with 361 additions and 336 deletions.
diff --git a/etc/messages.xml b/etc/messages.xml
@@ -6122,7 +6122,20 @@ if (shouldCalcHalting && (calculateHaltingProbability() &gt; 0) { }
     	<Details>
     		<![CDATA[
     		<p>This method uses Optional.equals(Optional.empty()). It is more readable and more clear just to use the Optional.isPresent()
-    		method to determine whether the reference exists or not.
+    		method to determine whether the reference exists or not. Use
+    		<br/>
+    		<pre><code>
+            Optional f = getSomeOptional();
+    		if (!f.isPresent()) {
+    		}
+    		</code></pre>
+    		rather than
+    		<br/>
+    		<pre><code>
+   			Optional f = getSomeOptional();
+   			if (f.equals(Optional.empty()) {
+   			}
+    		</code></pre>
     		</p>
     		]]>
     	</Details>