fixing e2e tasks in grunt and gulp, adding e2e tests for user module #936
Conversation
| "postinstall": "bower install --config.interactive=false" | ||
| "postinstall": [ | ||
| "bower install --config.interactive=false", | ||
| "./node_modules/protractor/bin/webdriver-manager update" |
There was a problem hiding this comment.
Can this be added as a Grunt task that is coupled with the protractor task? I'm concerned that not all users will want to deal with protractor & the e2e tests at the time of package install.
There was a problem hiding this comment.
Something like this in the Grunt file would probably suffice..
https://github.com/meanjs/mean/blob/master/gulpfile.js#L198
There was a problem hiding this comment.
What do you think about this?
There was a problem hiding this comment.
If we use that package, would we still be required to run the server with our protractor test task? I couldn't tell from the documentation.
Either way, grunt-protractor-webdriver looks promising. I'm gonna take a shot at testing it.
|
@jloveland I think there's a bit too much going on with this PR. I'm worried it will take some time to review. Would it be possible to just add the protractor task to the Grunt file, and fix the existing e2e tests? Perhaps in a separate PR; that way you can keep all this work here. With that approach we would get the bug fix for the Protractor tests out quickly, and then we could start building out the e2e tests. |
|
@mleanos, I agree, I will separate into different PRs. |
fixes #929 and #934