This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Reopened: Force Username & Email to Lowercase + Remove Sensitive Data #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
almegdad
commented
Aug 31, 2015
- add directive to force username & email to lowercase
- remove sensitive data in password reset
- 2 spaces indentation in reset & forgot password views
| element.css('text-transform', 'lowercase'); | ||
| } | ||
| }; | ||
| }); |
There was a problem hiding this comment.
updated: new line added
|
@almegdad Your missing a new line at the end of the users.client.directive.js file. Other than that, it looks good to me! |
* add directive to force username & email lowercase * remove sensitive data in password reset * 2 space indentation in reset & forgot password views
|
LGTM |
lirantal
added a commit
that referenced
this pull request
Sep 2, 2015
Reopened: Force Username & Email to Lowercase + Remove Sensitive Data
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.