This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Fixed bug with Socket IO session #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
f7771bb to
42e83e8
Compare
|
Re-worked the error handling. Using the |
42e83e8 to
8675841
Compare
|
Attempted to fix the spacing issues.. I removed automatic indentation on new lines. @rhutchison How does it look to you now? |
New enhancements to the Express session, added "sessionId" as the new default session key. Previously, the express session was using the default "connect.sid" key. This caused the Socket configuration to be unable to find the session id, thus causing issues with the Socket. One suck issue, was that the same Socket would be used for all users connected to the server. This also adds a bit more error handling of the Socket server configuration. Using the `return next()` pattern.
8675841 to
792488e
Compare
|
LGTM Tested, and verified that it works. |
|
LGTM - thanks |
|
Thanks @mleanos and @rhutchison @codydaig for reviewing! |
lirantal
added a commit
that referenced
this pull request
Aug 17, 2015
Fixed bug with Socket IO session
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New enhancements to the Express session, added "sessionId" as the new
default session key. Previously, the express session was using the
default "connect.sid" key. This caused the Socket configuration to be
unable to find the session id, thus causing issues with the Socket. One
such issue, was that the same Socket would be used for all users
connected to the server.
This also adds a bit more error handling of the Socket server
configuration.