This repository has been archived by the owner on Aug 30, 2021. It is now read-only.
Adding suite of tests for the e-mail validation field in the users model #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lirantal Not that having more tests is a bad thing, but we are using validator so wouldn't this be overkill? Guessing that module has the proper tests already. Unless there is a way to add email outside of validator, which would probably be bad. The more tests we have the longer CI takes. |
|
LGTM. |
|
@trainerbill that's exactly the point - imagine a scenario that someone in the future will replace the Also I wouldn't worry that much about tests time and rather would aim for a high code coverage. |
lirantal
added a commit
that referenced
this pull request
Aug 14, 2015
Adding suite of tests for the e-mail validation field in the users model
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This further strengthens our test suites from 21 tests to 35 already!