Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Typo in page-title.client.directives.js #1332

Closed
aanev opened this issue May 10, 2016 · 2 comments · Fixed by #1343
Closed

Typo in page-title.client.directives.js #1332

aanev opened this issue May 10, 2016 · 2 comments · Fixed by #1343
Assignees
@ilanbiala
Labels
issue:bug
Milestone
0.5.0

Comments

@aanev
Copy link
Contributor

aanev commented May 10, 2016

Line 11 in "mean/modules/core/client/directives/page-title.client.directives.js" is

retrict: 'A',

and should be

restrict: 'A',
@ilanbiala
Copy link
Member

@aanev can you submit a PR?

@ilanbiala ilanbiala self-assigned this May 10, 2016
@ilanbiala ilanbiala added this to the 0.5.0 milestone May 10, 2016
@lirantal
Copy link
Member

@aanev you created a PR in your own repo (https://github.com/aanev/mean/pull/1) but you actually need to make the PR for the code change to the meanjs repo so that @ilanbiala can help you merge it.

@aanev aanev closed this as completed May 19, 2016
@aanev aanev mentioned this issue May 19, 2016
Closed
@lirantal lirantal reopened this May 19, 2016
@aanev aanev mentioned this issue May 20, 2016
Merged
lirantal pushed a commit that referenced this issue May 20, 2016
@aanev @lirantal
fix(core): Typo in page-title.client.directives.js (#1343)
c61640b 
fix typo in modules/core/client/directives/page-title.client.directives.js

Fixes #1332
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilanbiala ilanbiala

Labels
issue:bug
Projects
None yet
Milestone
0.5.0
3 participants
@lirantal @ilanbiala @aanev