Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(curve/migrationRegistry): access control #87

Merged
merged 4 commits into from
Jan 17, 2022
Merged

feat(curve/migrationRegistry): access control #87

merged 4 commits into from
Jan 17, 2022

Conversation

pegahcarter
Copy link
Member

No description provided.

@zgorizzo69 zgorizzo69 requested a review from parv3213 January 14, 2022 11:32
@pegahcarter
Copy link
Member Author

@zgorizzo69 Still have this commented out:

meTokens-core/test/contracts/curves/helper/curvesTestsHelper.ts

Line 50 in 1650f20

TODO (Ben): what should we do w/ these tests

Can we uncomment these funcs out and have them called through hub.register()? Then we can remove the Ownable usage on curve contracts

@pegahcarter pegahcarter merged commit 6130b36 into main Jan 17, 2022
@pegahcarter pegahcarter deleted the fix/access-control branch January 27, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parv3213 parv3213 Awaiting requested review from parv3213

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pegahcarter @zgorizzo69