fix(precision): increase amount to test precision

[zgorizzo69]

No description provided.

[zgorizzo69]

yarn test test/integration/Hub/UpdateCurveDetails.ts fails
it doesn't come from the toETH function cos if we remove it the result is the same
and there is no caculation from ts code as we compare what foundry.calculateMeTokensMinted returns and the amount of metoken we actually receive
so it should come from the fee

[zgorizzo69]

it is not the fee it is because somehow calculateMeTokensMinted doesn't returns the same thing when I call it before minting and when it is called inside the mint function . My guess is the weighted average is a little bit different because on the time spent when I ask for the calculateMeTokensMinted block timestamp is a little lower than when it is called inside the mint function

[pegahcarter]

it is not the fee it is because somehow calculateMeTokensMinted doesn't returns the same thing when I call it before minting and when it is called inside the mint function . My guess is the weighted average is a little bit different because on the time spent when I ask for the calculateMeTokensMinted block timestamp is a little lower than when it is called inside the mint function

are you sure? Shouldn't we be on the same block

[zgorizzo69]

it is not the fee it is because somehow calculateMeTokensMinted doesn't returns the same thing when I call it before minting and when it is called inside the mint function . My guess is the weighted average is a little bit different because on the time spent when I ask for the calculateMeTokensMinted block timestamp is a little lower than when it is called inside the mint function

are you sure? Shouldn't we be on the same block

This is weird indeed I double checked only one tx so block height must be the same...

[pegahcarter]

Try comparing output to BancorPower to see if precision issue still persists

[zgorizzo69]

it is not the fee it is because somehow calculateMeTokensMinted doesn't returns the same thing when I call it before minting and when it is called inside the mint function . My guess is the weighted average is a little bit different because on the time spent when I ask for the calculateMeTokensMinted block timestamp is a little lower than when it is called inside the mint function

are you sure? Shouldn't we be on the same block

This is weird indeed I double checked only one tx so block height must be the same...

it is indeed because block.timestamp is slightly different between when we ask for the foundry.calculateMeTokensMinted and when we mint it when we calculate the weighted average

[zgorizzo69]

WA targetAmount > amount targetAmount:688041225234449977308 amount:1282213392634488692

WA targetAmount > amount block.timestamp:1633906778 startTime:1633816758 endTime:1634421558

targetCurve ==== address(0) meTokensMinted:103501205201497303317

WA targetAmount > amount targetAmount:688041225234449977308 amount:1282213392634488692

WA targetAmount > amount block.timestamp:1633906780 startTime:1633816758 endTime:1634421558

targetCurve ==== address(0) meTokensMinted:103503476229975616198

[pegahcarter]

automine helper func and usage look good 👍