Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Soonest #145

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Remove Soonest #145

merged 2 commits into from
Apr 8, 2022

Conversation

parv3213
Copy link
Member

@parv3213 parv3213 commented Apr 8, 2022

No description provided.

@parv3213 parv3213 requested a review from pegahcarter April 8, 2022 11:06
@parv3213
Copy link
Member Author

parv3213 commented Apr 8, 2022

This PR reduces a total of 49410 gas from deployments and 22535 gas from average calls.

@parv3213 parv3213 self-assigned this Apr 8, 2022
@@ -236,6 +236,16 @@ const setup = async () => {

await expect(tx).to.not.emit(initialVault, "StartMigration");
});
it("should be able to call when migration before startTime(), but wont run startMigration()", async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test

@pegahcarter pegahcarter merged commit 75ecdea into main Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants