Slippage Check #143
Merged
Slippage Check #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `_swap` cost increases by around 10% - Issue with setting correct amountIn for getting correct amountOut. - For example, while swapping DAI -> WETH, we cannot set amountIn to be just 1. -> As then the amountOut will be 0.
7083f8d to
e305865
Compare
|
We need additional coverage for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Uniswap quoter to get amountOut for small amountIn. Assuming for this small amount the slippage percentage is 0, calculate the asset price. Then while calling actual swap, pass amountOut as
amountIN*assetPrice*slippagePercent. This would ensure the assets aren't migrated at unexpected slippage.Issues:
_swapcost increases by around 10%@zgorizzo69 @cartercarlson