Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/cleanup #122

Merged
merged 22 commits into from
Feb 26, 2022
Merged

Refactor/cleanup #122

merged 22 commits into from
Feb 26, 2022

Conversation

pegahcarter
Copy link
Member

No description provided.

Copy link
Collaborator

@zgorizzo69 zgorizzo69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renaming, inheritance makes more sense ! good job 👍

const curve = await deploy<BancorABDK>(
"BancorABDK",
const curve = await deploy<BancorCurve>(
"BancorCurve",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense now that we only have one version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pegahcarter pegahcarter merged commit 9e98ea8 into main Feb 26, 2022
@pegahcarter pegahcarter deleted the refactor/cleanup branch March 8, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants