Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: ownership facet #121

Merged
merged 4 commits into from
Feb 26, 2022
Merged

Test: ownership facet #121

merged 4 commits into from
Feb 26, 2022

Conversation

parv3213
Copy link
Member

No description provided.

@parv3213 parv3213 requested a review from pegahcarter February 23, 2022 12:55
@parv3213 parv3213 self-assigned this Feb 23, 2022
@parv3213
Copy link
Member Author

@cartercarlson just a note, If we remove the require checks for comparing new and old addresses in the OwnershipFacet, then we can save 26% on deployment plus 3% on each consecutive call.

@pegahcarter
Copy link
Member

@cartercarlson just a note, If we remove the require checks for comparing new and old addresses in the OwnershipFacet, then we can save 26% on deployment plus 3% on each consecutive call.

Very solid. Let's' do it :D

@parv3213
feat: optimise-
5843ec5 
- 16% reduction in deployment costs
- 0.186921347% increase in call costs
zgorizzo69
zgorizzo69 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@zgorizzo69 zgorizzo69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job 🥇

@pegahcarter pegahcarter changed the base branch from refactor/tests to main February 26, 2022 00:55
@pegahcarter pegahcarter merged commit bb97490 into main Feb 26, 2022
@pegahcarter pegahcarter deleted the test/OwnershipFacet branch March 8, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pegahcarter pegahcarter pegahcarter approved these changes

@zgorizzo69 zgorizzo69 zgorizzo69 approved these changes

Assignees

@parv3213 parv3213

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parv3213 @pegahcarter @zgorizzo69