test(MeTokenRegistry): multiple differences #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differences: 1. Curve details: encodedBancorDetails - encodedStepwiseDetails 2. Curves: bancorABDK - stepwiseCurveABDK 3. Refund ratio: initialRefundRatio - targetRefundRatio
zgorizzo69
requested changes
Feb 9, 2022
| new Decimal(assetsReturned).sub(new Decimal(burnFee)).toNumber(), | ||
| 1e-15 | ||
| ); | ||
| expect(ownerMeTokenAfter).to.equal(0); |
There was a problem hiding this comment.
at the end of the warmup metoken supply is zero which is probably never gonna happen
I think It would be interesting to have still metoken and dai in the vault before the migration and check that
it is converted to weth after the migration
There was a problem hiding this comment.
Few similar tests are already covered in other test files, like here- https://github.com/meTokens/meTokens-core/blob/test/resub-multi-change/test/contracts/migrations/UniswapSingleTransfer.ts#L336. Do we need to add it here as well?
zgorizzo69
approved these changes
Feb 9, 2022
pegahcarter
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differences: