Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes if add() is successful but send() is not, write() will return no bytes written however the bytes still get added in the queue to be sent #144

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixes if add() is successful but send() is not, write() will return no bytes written however the bytes still get added in the queue to be sent #144

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c10654
fixes if add() is successful but send() is not, write() will return n…
ZongyiYang Apr 10, 2022
7345318
change tabs to spaces
ZongyiYang Apr 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/AsyncTCP.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,9 +1017,12 @@ size_t AsyncClient::write(const char* data) {

size_t AsyncClient::write(const char* data, size_t size, uint8_t apiflags) {
size_t will_send = add(data, size, apiflags);
if(!will_send || !send()) {
if (!will_send) {
return 0;
}
while (connected() && !send()) {
taskYIELD();
}
return will_send;
}

Expand Down