refactor: move getShortLang outside markdown processor #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianMurphy
approved these changes
Mar 18, 2021
| @@ -49,6 +49,9 @@ ESLinter.prototype.verify = function ( | |||
| {} | |||
|
|
|||
| processorOptions.lintCodeBlocks = settings['mdx/code-blocks'] === true | |||
| processorOptions.languageMapper = settings[ | |||
| 'mdx/language-mapper' | |||
| ] as ProcessorOptions['languageMapper'] | |||
There was a problem hiding this comment.
Would it make sense for languageMapper to have it's own type/interface which could be used directly in this cast?
There was a problem hiding this comment.
Added a ESLintMdxSettings interface
But after digging some other plugins like https://github.com/yannickcr/eslint-plugin-react#configuration or https://github.com/mysticatea/eslint-plugin-node/blob/master/docs/rules/no-extraneous-import.md#shared-settings, a namespaced object settings could be used easyier.
{
"settings": {
"mdx": {
"codeBlocks": true,
"languageMapper": {}
}
}
}What do you think? And I don't know if it should be considered as BREAKING CHANGE, because it's very easy to migrate.
There was a problem hiding this comment.
|
Released! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{index}_prefix is hard coded at https://github.com/eslint/eslint/blob/master/lib/linter/linter.js#L1303