Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SNK Neo Geo Arcade Stick Pro on Mac OS X #818

Merged
merged 2 commits into from
Dec 29, 2024

Conversation

kemar
Copy link
Contributor

@kemar kemar commented Dec 29, 2024

Add support for SNK Neo Geo Arcade Stick Pro on Mac OS X.

Product page: https://www.snk-corp.co.jp/us/neogeoarcadestickpro/

@offalynne offalynne merged commit dba6588 into mdqinc:master Dec 29, 2024
@offalynne
Copy link
Collaborator

Thanks, would love to have Windows and Linux as well in the future if you're able 👍

@kemar
Copy link
Contributor Author

kemar commented Dec 29, 2024

Thanks for merging the PR!

My only computer is a Mac right now, so I cannot map the stick for Windows and Linux 😔

@offalynne
Copy link
Collaborator

offalynne commented Jan 11, 2025

@kemar how did you map the buttons ? did you follow the "Arcade" format per the REAMDE graphic https://github.com/mdqinc/SDL_GameControllerDB/blob/master/mapping_guide.png ?

@kemar
Copy link
Contributor Author

kemar commented Jan 12, 2025

@offalynne I used SDL2 Gamepad Tool but didn't pay attention to the note.

Does this break something? And if so, how to fix it?

@offalynne

This comment was marked as outdated.

@offalynne

This comment was marked as outdated.

@offalynne
Copy link
Collaborator

I've got in touch with another user who has clarified all of the above -- no further follow up is needed 👍

@kemar
Copy link
Contributor Author

kemar commented Jan 12, 2025

I've got in touch with another user who has clarified all of the above -- no further follow up is needed 👍

Cool because I didn't understand what could possibly be wrong with this mapping 😄

@offalynne
Copy link
Collaborator

Since there are 2 modes with conflicting GUIDs and different button layouts, I'm going to remove this mapping. If you want to revisit this in the future, you can contribute an upstream mapping to SDL, since SDL's db includes duplicate GUIDs differentiated on device CRC. (See https://github.com/mdqinc/SDL_GameControllerDB?tab=readme-ov-file#sdl)

@kemar
Copy link
Contributor Author

kemar commented Jan 14, 2025

Ok @offalynne I understand.

Do you mean contributing to https://github.com/libsdl-org/SDL?

@offalynne
Copy link
Collaborator

offalynne commented Jan 14, 2025

@kemar
Copy link
Contributor Author

kemar commented Jan 14, 2025

Ok thanks, that's very clear. I may try this in the coming weeks but I'll need to learn a bit about C.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants