Fix problem with extra characters in subtitle #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .caption files consist of subtitle text and timestamps with some binary data interposed. When converted to text, this binary data produces random, mostly unprintable characters. Many can be filtered out, but printable characters are sometimes overlooked and end up in the subtitle. This problem can be overcome by taking a different approach. Study revealed that the subtitle text and timestamp data appears at predictable positions in the .caption file. This commit replaces the filter method with one that makes use of this principle, extracting only text and timestamps and leaving out any binary data.
|
I'm adding some proof of my claim of improved accuracy. Since the question came up in a different conversation, I did a comparison between my method and the recent changes made to LyndaCaptionToSrtConvertor. The resulting diff shows that the regex filter method still misses characters sometimes, where the extraction method converted correctly. |
mdomnita
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some modifications to the way subtitles are extracted. Looking closely at the .caption files, I discovered the timestamps and subtitles appear at predictable positions. This allows them to be separated from the binary data without needing to filter any characters. I tested this method on 16 courses, and so far I've only had good results.