Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented multi-section surface parameterization #446
Implemented multi-section surface parameterization #446
Changes from all commits
4805012
590a3ba
5d7bf46
65e2e3a
618786b
a1e5230
2135063
bc3da60
bec971e
d15d4d9
e3d014f
461fceb
5b4cc4e
e702d3b
340de02
07b9c4a
30ef1a1
42e722c
719126a
e9914aa
ab1d16c
273b6ac
471b0e2
7187589
f8c2590
e38f2b6
14c9ab5
869a2ff
2ed5818
da6860a
eabb891
8cd7b10
324705f
0f3769a
010b1d2
c78e2cb
c257b58
47676aa
4654437
b196140
6d19f0e
0b6afe0
3b4f2e2
0feee26
54533f4
a5d910d
abd0924
c10b6ee
83947e1
876ba8a
3f541c7
d41fe1a
8eb0dc5
dba1a17
4700e17
cbfc593
2c565ff
60812bb
f58e539
9e1fff2
4c6d342
83f681a
f37a9a9
110b0f8
c6ccc99
b9460b7
c7b9f97
6810a6b
12f5331
68deba1
2e562a5
8d939ca
0b859b4
d4c30fb
2fe8361
e268616
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you maybe want to put these example files in openaerostruct/examples because that's easier to find? I don't remember if that complicates the docs build or not though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't but none of the examples in the examples folder have doc checkpoint references like this one does. I can put copies in there though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I don't mind having doc checkpoints in the example file or keeping these in the current folder under docs as long as users can easily find them. And since you embedded all three files in the rst files it's good.
Either way, we should avoid putting two copies in difference places because that will make future maintenance difficult.