enhance(kumascript): make smartLink()'s content parameter optional
#9847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Derived by recording the types of all parameters during a full build of the English locale.
|
@wbamberg I'm curious to have your opinion on this, but I think this feeds into the path we had agreed on. |
Yeah, I think this is a good idea. I never really understood exactly what smartLink() though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Currently, kumascript's
smartLink()requires to pass the link text via thecontentparameter, but this link text could be automatically derived from the page'sshort-titleortitle, like we already do in some sidebar macros (e.g. PWASidebar)Solution
Make the
contentparameter optional and use the page'sshort-titleortitle, if available.How did you test this change?
Planning to use this in a follow-up PRs that removes translated page titles from sidebar macros.