Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): TypeScript errors when running yarn dev #8835

Merged
merged 1 commit into from
May 11, 2023
Merged

fix(dev): TypeScript errors when running yarn dev #8835

merged 1 commit into from
May 11, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented May 11, 2023

since updating to TypeScript 5 we've had errors like:
TypeError: Cannot set property mark of #<Object> which has only a getter

updating fork-ts-checker-webpack-plugin fixes the problem

Screenshots

Before

yarn dev
...
Creating an optimized production build...
TypeError: Cannot set property mark of #<Object> which has only a getter
TypeError: Cannot set property mark of #<Object> which has only a getter
    at Object.connectTypeScriptPerformance (/workspace/yari/node_modules/fork-ts-checker-webpack-plugin/lib/typescript-reporter/profile/TypeScriptPerformance.js:12:36)
...

After

yarn dev
...
Creating an optimized production build...
Compiled successfully.
...

How did you test this change?

Ran yarn dev, introduced a typescript error, observed it correctly log to console.

since updating to TypeScript 5 we've had errors like:
`TypeError: Cannot set property mark of #<Object> which has only a getter`

updating fork-ts-checker-webpack-plugin fixes the problem
@LeoMcA LeoMcA requested a review from caugner May 11, 2023 12:01
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 11, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LeoMcA LeoMcA merged commit 039515b into main May 11, 2023
@LeoMcA LeoMcA deleted the fix-ts-fork branch May 11, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants