Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(macros): deprecate {{warning}} macro #6994

Merged
merged 1 commit into from
Aug 29, 2022
Merged

chore(macros): deprecate {{warning}} macro #6994

merged 1 commit into from
Aug 29, 2022

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Aug 27, 2022

Summary

{{warning}} macro has been removed from mdn/content (mdn/content#20015).

It's time to deprecate it.

Note: there are some escaped {{warning}} macros in issue template:

https://github.com/mdn/content/blob/1c8f3af9f3c9e7caf084fd9072c263b86e25ac1b/files/en-us/mdn/community/issues/index.md?plain=1#L19-L35

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Aug 27, 2022
@teoli2003
Copy link
Contributor

Using warning in the issue template is not problematic, IMO.

@caugner caugner merged commit 68d8fa1 into mdn:main Aug 29, 2022
@yin1999 yin1999 deleted the patch-1 branch August 29, 2022 08:54
@yin1999 yin1999 mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yin1999 @teoli2003 @caugner