chore(document/toolbar): replace "Quick-Edit" by "Edit on GitHub" #6065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| className="button" | ||
| title={`You're going to need to sign in to GitHub first (Opens in a new tab)`} |
There was a problem hiding this comment.
Nit
Suggested change
| title={`You're going to need to sign in to GitHub first (Opens in a new tab)`} | |
| title="Edit on GitHub. Opens in a new tab" |
There was a problem hiding this comment.
I took it from here:
But maybe we don't need a title here at all? Since they're running yarn locally, they most likely have a GitHub account already, and opening in a new tab doesn't need to be advertised.
There was a problem hiding this comment.
In general, it is a good idea for accessibility to state that a link opens in a new tab if one forces it with _blank
There was a problem hiding this comment.
Good point, thank you, I have removed the _blank target, because there is no reason to enforce this.
schalkneethling
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
One suggestion but, other than that, this looks good to me. Thanks, @caugner 🎉
OnkarRuikar
pushed a commit
to OnkarRuikar/yari
that referenced
this pull request
Jun 2, 2022
…n#6065) * chore(app): remove quick-edit feature * chore(edit-actions): add "Edit on GitHub" link
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
We have a "Quick-edit" feature that (presumably) nobody uses (see #4866), because the GitHub editor is much better and allows opening a PR.
Solution
Screenshots
Before
After
How did you test this change?