-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bcd): Prioritize current support using a ranking system #5946
Conversation
client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Outdated
Show resolved
Hide resolved
26ef5e7
to
8bfa2b5
Compare
4f33aae
to
d7edb59
Compare
d7edb59
to
5f3ca4c
Compare
I've done the prioritization of support. As was expected, it is complex. If there are preferences for rewriting things a certain way, let me know. I did it with many return statements so that in most cases, not all the finds need to be run for each cell. I could have done a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few nits.
Summary
Fixes #5945
Problem
Current support is defined as the most recent support item:
yari/client/src/document/ingredients/browser-compatibility-table/feature-row.tsx
Line 139 in e93d4a5
However, look at innerHeight for Firefox on https://developer.mozilla.org/en-US/docs/Web/API/Window/innerHeight#browser_compatibility. It's had full support since version 1, but a removed note in effect from version 4-24. Because that item is newer and was removed, it looks like it has no support.
Solution
Rank the support items as follows:
version_removed === null
)version_added
)version_added
andnotes
No supportversion_removed !== null
)Screenshots
Before
After