Support giving spec URL as {{Specifications(...)}} argument #5329
Conversation
Related: mdn/content#13273 (comment) This change allows authors to give the Specifications macro a spec URL as an argument; like this: {{Specifications("https://w3c.github.io/webappsec-secure-contexts/")}}
| let browsers; | ||
| let data; |
There was a problem hiding this comment.
Where are browsers and data used, apart from their assignment?
| @@ -342,8 +342,17 @@ function _addSingleSpecialSection($) { | |||
| const [proseSections] = _addSectionProse($); | |||
| return proseSections; | |||
| } | |||
| const query = dataQuery.replace(/^bcd:/, ""); | |||
| const { browsers, data } = packageBCD(query); | |||
| let query = dataQuery.replace(/^bcd:/, ""); | |||
There was a problem hiding this comment.
It looks like this variable is only read once in the else branch.
Could you move it there and make it const?
| let browsers; | ||
| let data; | ||
|
|
||
| if (dataQuery && dataQuery.trim().match("^http[s]?://")) { |
There was a problem hiding this comment.
Could you add a short comment before this block explaining what it does / we need this?
|
@sideshowbarker Please see @caugner’s comments when you have a moment. Thank you. |
|
I’m closing this PR in favor of consideration for #5971 and #5972, which essentially would allow us to move completely away from ever using the The context is that #5347 (reply in thread) has persuaded me that it would be a good idea for us to move wholly over to just using the The specific parts of #5347 (reply in thread) I found persuasive were:
So #5971 and #5972 are also in line with our general de-macro-ization plans — in that they’d take us a big step closer to completely eliminating the |
Related: mdn/content#13273 (comment) • This changes allows authors to give the Specifications macro a spec URL as an argument; like this:
cc @wbamberg