Broken link checkers should fallback to en-US if possible #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's another good example on http://localhost:3000/ru/docs/Tools/Responsive_Design_Mode |
fiji-flo
approved these changes
Mar 16, 2021
This was referenced Mar 17, 2021
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
* Broken link checkers should fallback nicely to English if need be Fixes mdn#3104 * remove debugging * adding tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3104
Take http://localhost:3000/bg/docs/Web for example.
Compare it with https://developer.mozilla.org/bg/docs/Web
There are lots of broken links on that page (in Prod). And a lot of them are really broken because when you click on one of them (e.g. https://developer.mozilla.org/bg/docs/Web/Apps) you get a 404 Page not found, but without that helpful "Good news!" (green) message that it's available in English. That's because that Belarusian link is so broken and old that it doesn't check for redirects.
Now it becomes this: