simulate content-origin-request #3047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbe
commented
Feb 25, 2021
peterbe
commented
Feb 25, 2021
| @@ -70,6 +70,7 @@ exports.handler = async (event) => { | |||
| const path = request.uri.endsWith("/") | |||
| ? request.uri.slice(0, -1) | |||
| : request.uri; | |||
|
|
|||
peterbe
commented
Feb 25, 2021
|
@escattone Ok. Now, this new workflow runs some jest tests. I'm expecting it to fail actually because we don't yet have all your new changes. Basically, this PR won't pass until #2922 is merged. |
escattone
reviewed
Feb 26, 2021
Co-authored-by: Ryan Johnson <escattone@gmail.com>
escattone
approved these changes
Mar 2, 2021
peterbe
added a commit
to peterbe/yari
that referenced
this pull request
Jun 1, 2021
* simulate content-origin-request * specifics * oops * eslint * start server in background * polka is smaller * calm down eslint * debugging * node_modules caching * undebugging * add basic unit test start * eslint * querystring * more tests * more tests and stuff * tests updated based on feedback * way more conservative with caching node_modules * all feedback addressed * Update .github/workflows/content-origin-request.yml Co-authored-by: Ryan Johnson <escattone@gmail.com> Co-authored-by: Ryan Johnson <escattone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying out some stuff.