chore(test-build): support specificying rari and content branch #12432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
reviewed
Jan 10, 2025
caugner
approved these changes
Jan 13, 2025
.github/workflows/test-build.yml
Outdated
| @@ -119,9 +137,36 @@ jobs: | |||
| # See https://github.com/microsoft/vscode-ripgrep#github-api-limit-note | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
|
|
|||
| - name: Print information about build | |||
| - uses: actions/checkout@v4 | |||
| if: ${{ ! vars.SKIP_BUILD && github.event.inputs.rari-ref != '' }} | |||
There was a problem hiding this comment.
Nit: These !a && b != "" conditions confused me a bit. How about:
Suggested change
| if: ${{ ! vars.SKIP_BUILD && github.event.inputs.rari-ref != '' }} | |
| if: ${{ ! vars.SKIP_BUILD || github.event.inputs.rari-ref == '' }} |
There was a problem hiding this comment.
I guess you missed some brackets and mean !( vars.SKIP_BUILD || github.event.input.rari-ref == '' ) I tend to find NNF more understandable, but in this case I agree a big wrapping negation makes sense and turns the if into an unless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds rari if branch is given as workflow input
Tested across multiple runs of the test build: https://github.com/mdn/yari/actions/workflows/test-build.yml