Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(syntax-highlight): enable Go language, set tab-size to 4 #11608

Merged
merged 2 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/syntax-highlight.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const loadAllLanguages = lazy(() => {
"diff",
"django",
"glsl",
"go",
"handlebars",
"http",
"ignore",
Expand Down
1 change: 1 addition & 0 deletions client/src/document/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ code,
border-radius: var(--elem-radius);
font-family: var(--font-code);
font-size: var(--type-smaller-font-size);
tab-size: 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right to assume we don't use tabs in code samples for other languages, so this shouldn't affect any existing code samples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could only find one occurrence here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify#using_the_space_parameter

using:

grep -ri --binary-files=without-match --exclude="./files/en-us/_redirects.txt" " " ./files

}

code {
Expand Down