Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Inter wouldn't load on Linux 🐧 #11491

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Jul 17, 2024

Summary

Problem

Inter has never loaded for me in local development, I always had to comment out the @font-face declaration and load it locally, but I never dug into why this was happening.

Solution

Don't lowercase everything by default in the server, first attempt to load the actual path, then if nothing is found horrifically mutate it to satisfy the absurdities introduced by appeasing the use of filesystems which quite clearly exhibit incorrect behaviour.


How did you test this change?

Use a sensitive filesystem
yarn && yarn dev
visited http://localhost:5042/en-US/docs/Web
Inter loads! 🎉

fixes loading any file with mixed case on a case sensitive filesystem
@LeoMcA LeoMcA requested a review from a team as a code owner July 17, 2024 16:55
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 yay

@LeoMcA LeoMcA merged commit 5ceaaa1 into main Jul 18, 2024
12 checks passed
@LeoMcA LeoMcA deleted the fix-server-linux-fonts branch July 18, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants