Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync-translated-content): preserve l10n frontmatter #11224

Merged
merged 1 commit into from
May 31, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 31, 2024

Summary

Fixes an issue with sync-translated-content encountered in mdn/translated-content#21044 (comment).

Problem

Our sync-translated-content tool removes the l10n frontmatter key.

Solution

Add l10n to the list of optional front matter keys.


How did you test this change?

  • Checked out mdn/content @ b68d6456477c19b1fed8fc6bc99eff8972b1af29
  • Checked out mdn/translated-content @ f5db1f7163d985ff55b90d11f1efe2fc34ad3445
  • Ran yarn tool sync-translated-content ko
  • Verified the diff of files/ko/glossary/gzip_compression/index.md:

Before

diff --git a/files/ko/glossary/gzip_compression/index.md b/files/ko/glossary/gzip_compression/index.md
index 2662038da6..087779623b 100644
--- a/files/ko/glossary/gzip_compression/index.md
+++ b/files/ko/glossary/gzip_compression/index.md
@@ -1,8 +1,6 @@
 ---
 title: GZip 압축 (GZip compression)
-slug: Glossary/GZip_compression
-l10n:
-  sourceCommit: ada5fa5ef15eadd44b549ecf906423b4a2092f34
+slug: Glossary/gzip_compression
 ---
 
 {{GlossarySidebar}}

After

diff --git a/files/ko/glossary/gzip_compression/index.md b/files/ko/glossary/gzip_compression/index.md
index 2662038da6..0e12e51c7a 100644
--- a/files/ko/glossary/gzip_compression/index.md
+++ b/files/ko/glossary/gzip_compression/index.md
@@ -1,6 +1,6 @@
 ---
 title: GZip 압축 (GZip compression)
-slug: Glossary/GZip_compression
+slug: Glossary/gzip_compression
 l10n:
   sourceCommit: ada5fa5ef15eadd44b549ecf906423b4a2092f34
 ---

@caugner caugner requested a review from a team as a code owner May 31, 2024 11:17
@caugner caugner merged commit 66653b7 into main May 31, 2024
12 checks passed
@caugner caugner deleted the preserve-l10n-frontmatter-on-sync branch May 31, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants