Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix form submitting problem in playground #10819

Merged
merged 1 commit into from
Apr 2, 2024
Merged

fix form submitting problem in playground #10819

merged 1 commit into from
Apr 2, 2024

Conversation

hanyujie2002
Copy link
Contributor

@hanyujie2002 hanyujie2002 commented Apr 1, 2024 •
edited by caugner
Loading

Relates to #10788

BEGIN_COMMIT_OVERRIDE
fix(playground): allow forms in iframe
END_COMMIT_OVERRIDE

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner April 1, 2024 04:37
fiji-flo
fiji-flo approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, we started with strong restrictions but this is an absolute valid case with minimal security implications.

@fiji-flo fiji-flo merged commit 1ffb026 into mdn:main Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fiji-flo fiji-flo fiji-flo approved these changes

Assignees
No one assigned
Labels
plus:playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanyujie2002 @fiji-flo