fix(telemetry): measure link/button clicks properly #10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We assumed that the click happens on the element with data-glean, but this is not guaranteed if the link/button has children.
fiji-flo
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(Related: MP-906)
Problem
We assumed that the click happens on the element with
data-glean, but this is not guaranteed if the link/button has children.Solution
Determine the closest link/button before checking for the
data-gleanattribute.How did you test this change?
Tested locally. Clicked in the sidebar banner (a) on the image, (b) on the text, and (c) slightly below the text, and verified that the click is measured in all three cases.