-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(article-footer): redesign footer + add feedback buttons #10625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
MP-907-article-footer-redesign
branch
from
March 1, 2024 16:13
7062a07
to
2d3bc43
Compare
This reverts commit 720f3d3.
argl
approved these changes
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looks good to me.
caugner
force-pushed
the
MP-907-article-footer-redesign
branch
from
March 5, 2024 15:31
e02ed1c
to
e1a178d
Compare
Hey @caugner. It would be nice if the "Learn how to contribute" link in translated documentations could be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-907)
Problem
We don't know how helpful our articles are.
Solution
Allow users to give feedback via a redesigned article footer.
Measurements:
thumbs: article_footer -> 0
thumbs: article_footer -> 1
article_footer: feedback -> outdated
article_footer: feedback -> incomplete
article_footer: feedback -> code_examples
article_footer: feedback -> other
Screenshots
Feedback
How did you test this change?
Ran
yarn dev
and opened http://localhost:3000/en-US/docs/Web#developer_tools_documentation locally.Enabled
REACT_APP_GLEAN_DEBUG=true
andREACT_APP_GLEAN_ENABLED=true
temporarily and checked that all events are properly measured via https://debug-ping-preview.firebaseapp.com/pings/mdn-dev.