Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(article-footer): redesign footer + add feedback buttons #10625

Merged
merged 31 commits into from
Mar 5, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 1, 2024

Summary

(MP-907)

Problem

We don't know how helpful our articles are.

Solution

Allow users to give feedback via a redesigned article footer.

Measurements:

Click source Explanation
thumbs: article_footer -> 0 User clicked on "Yes"
thumbs: article_footer -> 1 User clicked on "No"
article_footer: feedback -> outdated User submitted "Content is out of date"
article_footer: feedback -> incomplete User submitted "Missing information"
article_footer: feedback -> code_examples User submitted "Code examples not working as expected"
article_footer: feedback -> other User submitted "Other"

Screenshots

Theme Before After
Light image image
Dark image image

Feedback

Action Light Dark
Hover over "Yes" button image image
Hover over "No" button image image
After click on "No" button image image
After click on "Yes" button / After submit feedback form image image

How did you test this change?

Ran yarn dev and opened http://localhost:3000/en-US/docs/Web#developer_tools_documentation locally.

Enabled REACT_APP_GLEAN_DEBUG=true and REACT_APP_GLEAN_ENABLED=true temporarily and checked that all events are properly measured via https://debug-ping-preview.firebaseapp.com/pings/mdn-dev.

@caugner caugner requested a review from a team as a code owner March 1, 2024 10:33
@github-actions github-actions bot added plus work around features related to MDN Plus metrics labels Mar 1, 2024
@caugner caugner force-pushed the MP-907-article-footer-redesign branch from 7062a07 to 2d3bc43 Compare March 1, 2024 16:13
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks good to me.

@caugner caugner force-pushed the MP-907-article-footer-redesign branch from e02ed1c to e1a178d Compare March 5, 2024 15:31
@caugner caugner enabled auto-merge (squash) March 5, 2024 15:32
@caugner caugner merged commit 40659a8 into main Mar 5, 2024
26 checks passed
@caugner caugner deleted the MP-907-article-footer-redesign branch March 5, 2024 15:35
@yin1999
Copy link
Member

yin1999 commented Mar 12, 2024

Hey @caugner. It would be nice if the "Learn how to contribute" link in translated documentations could be https://github.com/mdn/translated-content/blob/main/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics plus work around features related to MDN Plus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants