fix(plus): scroll to anchor hook #10364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When navigating to a page via anchor link, scroll to the anchor via JS. We need this for non SSRed pages (mainly plus). Correct scroll-margins is only supported Firefox (via :target) fully. For some reason Blink and WebKit seem to not set :target consitently. To work around this we set scroll-margin for section[id], too.
argl
approved these changes
Jan 23, 2024
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a scroll to anchor hook.
When navigating to a page via anchor link, scroll to the anchor via JS. We need this for non SSRed pages (mainly plus)
Correct scroll-margins is only supported Firefox (via :target) fully. For some reason Blink and WebKit seem to not set :target consitently. To work around this we set scroll-margin for section[id], too.
How did you test this change?
Locally