fix(history): show outline on focus-visible #10343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
reviewed
Jan 22, 2024
There was a problem hiding this comment.
Small nit re. the PR/commit message:
- fix(history): show outline on focus-visible
+ fix(ai-help): show history outline on focus-visibleOther than that, I wonder if this would merit being a fade-out-right helper class or similar, to be able to reuse it and mainly not to repeat this error.
The mask-image was hiding the outline. Let's use ellipsis instead when focus-visible.
b3cc413 to
acac58a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The mask-image was hiding the outline.
Let's use ellipsis instead when focus-visible.
Screenshots
Before
After
How did you test this change?
Locally