Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): use pg instead of supabase #10337

Merged
merged 6 commits into from
Jan 29, 2024
Merged

feat(scripts): use pg instead of supabase #10337

merged 6 commits into from
Jan 29, 2024

Conversation

fiji-flo
Copy link
Contributor

Summary

Move to node-postgres to enable local postgres without supabase and enable us to move to our central DB in the future.

How did you test this change?

Locally

@fiji-flo fiji-flo requested review from mdn-bot and a team as code owners January 17, 2024 16:18
@github-actions github-actions bot added dependencies Pull requests that update a dependency file github-actions labels Jan 17, 2024
scripts/ai-help-macros.ts Fixed Show fixed Hide fixed
@@ -56,7 +57,14 @@ export async function updateEmbeddings(
}

// Supabase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super tiny little nitty-nit: At this point, it is not about Supabase any more, it should be Postgres.

scripts/ai-help-macros.ts Outdated Show resolved Hide resolved
@fiji-flo fiji-flo requested a review from argl January 19, 2024 09:01
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 22, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 22, 2024
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 26, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label Jan 29, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fiji-flo fiji-flo merged commit 5ce3a65 into main Jan 29, 2024
16 checks passed
@fiji-flo fiji-flo deleted the ai-context-use-pg branch January 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants