fix(macros/CSSSyntax): cache parsed webref data #10225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07ba073 to
74dc950
Compare
The truth is that this was a recently introduced performance regression. Until early December, the build time had been stable around 15min for some time. And we had noticed the regression only after the EOY production freeze had started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The
CSSSyntaxmacro attributes for a significant amount of render time, and has caused our full builds to take 1.5 hours.Solution
Cache parsed webref data to avoid duplicate work and improve performance.
Screenshots
Before
After
How did you test this change?
Kicked off a stage-build on this branch, see: