Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(baseline): bcd link not localized #10124

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix(baseline): bcd link not localized #10124

merged 2 commits into from
Dec 4, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented Dec 4, 2023

https://mozilla-hub.atlassian.net/browse/MP-668
#9848

This isn't a complete fix: some Portuguese pages need #compatibilidade_com_navegadores others need #compatibilidade_de_navegadores, I chose the former because more pages used that. This fix does at least reduce the number of pages on which the link doesn't work.

Backported from the baseline-next work, so already in QA.

@LeoMcA LeoMcA requested a review from caugner December 4, 2023 14:53
@LeoMcA LeoMcA requested a review from a team as a code owner December 4, 2023 14:53
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one non-blocking nit.

client/src/document/baseline-indicator.tsx Outdated Show resolved Hide resolved
@LeoMcA LeoMcA merged commit 0761a86 into main Dec 4, 2023
15 checks passed
@LeoMcA LeoMcA deleted the baseline-bcd-locale-fix branch December 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants