Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left Navigation Bar not Works Properly #8494

Closed
3 tasks done
akonitx opened this issue Mar 25, 2023 · 12 comments · Fixed by #8512
Closed
3 tasks done

Left Navigation Bar not Works Properly #8494

akonitx opened this issue Mar 25, 2023 · 12 comments · Fixed by #8512
Assignees
Labels
🐛 bug Something isn't working, or isn't working as expected p0 Urgent. We will address this as soon as possible. sidebar/toc Sidebar and table of contents

Comments

@akonitx
Copy link

akonitx commented Mar 25, 2023

Summary

Left nav scroll bar not works. As i cheked it doesn’t work nor in Chrome and nor in Firefox.
Youtube link for screen recorder.

URL

Is appear anywhere in your site where is left scroll nav bar.

Reproduction steps

Expected behavior

Nav scroll bar should scroll

Actual behavior

not scrolling

Device

Laptop

Browser

Chrome

Browser version

Stable

Operating system

Mac OS

Screenshot

No response

Anything else?

No response

Validations

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Mar 25, 2023
@jasonren0403
Copy link
Contributor

nor in Edge also :(

image

@deepug9787
Copy link

The display: contents set on the .sidebar-container appears to be the culprit.

This was referenced Mar 25, 2023
@Disney-Banje
Copy link

Yes the left aside guide section is unresponsive
developer mozilla org_en-US_docs_Learn (1)

@gekasam
Copy link

gekasam commented Mar 25, 2023

For some unknown reason, sidebar scrolling disappears. If you reduce the width of the view - appears.
Disabling extensions doesn't help.
Chrome 111.0.5563.111 x64 / Mozilla
Win 10

Screenshot_1
Screenshot_2

@caugner
Copy link
Contributor

caugner commented Mar 27, 2023

@akonitx @jasonren0403 @gekasam @yashwithgm We have not been able to reproduce the issue yet.

  1. Can you please try and run Chrome/Edge/Firefox with extensions disabled (e.g. chrome --disable-extensions) and verify if the issue persists?
  2. What are the exact versions of Chrome/Edge/Firefox you're using, an on what operating system?
  3. What are your screen resolutions?

@jasonren0403
Copy link
Contributor

jasonren0403 commented Mar 27, 2023

@akonitx @jasonren0403 @gekasam @yashwithgm We have not been able to reproduce the issue yet.

  1. Can you please try and run Chrome/Edge/Firefox with extensions disabled (e.g. chrome --disable-extensions) and verify if the issue persists?
  2. What are the exact versions of Chrome/Edge/Firefox you're using, an on what operating system?
  3. What are your screen resolutions?

I am running windows 11 on 1920x1080 screen, and my Edge version is 111.0.1661.54.
Disabling extensions did not resolve the issue.

Addtional: when I drag the width under 1200px on responsive mode, when "In this article" appear on the left side of the page, the scrollbar is working again then.

@akonitx
Copy link
Author

akonitx commented Mar 27, 2023

  1. Can you please try and run Chrome/Edge/Firefox with extensions disabled (e.g. chrome --disable-extensions) and verify if the issue persists?
    Yes, it persists.
  2. What are the exact versions of Chrome/Edge/Firefox you're using, an on what operating system?
    Chrome: Version 111.0.5563.110 (Official Build) (x86_64)
    FireFox: Version 111.0.1 (64-bit)
  3. What are your screen resolutions?
    3072‑by‑1920

My device: MacBook Pro (16-inch, late 2019)
link with same issue but without any extensions(using Chrome Inkognito tab and Firefox Private Mode)

But with more tab or phone resoutions like 845x664 all woks fine. And as you know you can check differnet resolutions in Developer Mode.

@yashwithgm
Copy link

  1. Tested on Both Google Chrome and Mozilla Firefox with extensions disabled, still the issue persists.
  2. Chrome version - 111.0.5563.111, Firefox version - 110.0.1 on Windows 11
  3. Resolution - 1366 x 768

@akonitx akonitx changed the title Left Navigation Bar Works not Properly Left Navigation Bar not Works Properly Mar 27, 2023
@caugner caugner added p0 Urgent. We will address this as soon as possible. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Mar 27, 2023
@caugner
Copy link
Contributor

caugner commented Mar 27, 2023

Thank you, we were able to reproduce the issue with a reduced width of <768px and are working on a fix. Sorry for the inconvenience! 🙏

fiji-flo added a commit to fiji-flo/yari that referenced this issue Mar 27, 2023
fiji-flo added a commit that referenced this issue Mar 27, 2023
* fix(sidebar): fix scrolling behavior.

fixes #8494

- .sidebar-inner is a grid when < screen-md
  - this allows to use display: contents on .sidebar-inner-nav
    and more the .place up via grid-row: 2/3
- screen-height-place-limit introduced to have central place for it
- on screens > screen-md and height < screen-height-place-limit:
  use .use display flex on .sidebar-inner and block on sidebar-inner
  nav to revert the gird again
- .toc-container: overflow: auto to remove scroll bars
@akonitx
Copy link
Author

akonitx commented Mar 27, 2023

Thank you, we were able to reproduce the issue with a reduced width of <768px and are working on a fix. Sorry for the inconvenience! 🙏

Thanks and good luck. Your documentation and Developer mode is awesome!

@fiji-flo
Copy link
Contributor

Fix should be fully rolled out now.

@deepug9787
Copy link

@fiji-flo It's working now! Thank you very much.

This was referenced Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working, or isn't working as expected p0 Urgent. We will address this as soon as possible. sidebar/toc Sidebar and table of contents
Projects
None yet
8 participants