Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't include non-image file attachments #3984

Closed
peterbe opened this issue Jun 7, 2021 · 2 comments
Closed

Can't include non-image file attachments #3984

peterbe opened this issue Jun 7, 2021 · 2 comments
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.

Comments

@peterbe
Copy link
Contributor

peterbe commented Jun 7, 2021

The problem is described here: mdn/content#5606
You can put a screenshot.png, for example, next to the index.(html|md) file and it will be picked up even though there might not be a single <img src="screenshot.png"> in the rendered and parsed HTML.
However, we only check for images. We need to support other somewhat arbitrary files too.

@peterbe
Copy link
Contributor Author

peterbe commented Jun 7, 2021

One temporary and possible solution for mdn/content#5606 is to correct the CORS headers on that S3 serving. But we want to get away from using Kuma for the content.

The advantage of being able to check in the images into the content is self-containment. Now all the content is available offline. No need to depend on a centralized internet server.

peterbe added a commit to peterbe/yari that referenced this issue Jun 7, 2021
@github-actions github-actions bot added the 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up. label Dec 8, 2021
Repository owner moved this from Backlog to Done in Yari Platform Engineering May 28, 2022
@caugner
Copy link
Contributor

caugner commented Nov 15, 2022

Closing in favor of duplicate #5727.

@caugner caugner closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.
Projects
Development

No branches or pull requests

3 participants