Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check of unsafe HTML in SVG files #3249

Closed
peterbe opened this issue Mar 15, 2021 · 1 comment · Fixed by #3250
Closed

Check of unsafe HTML in SVG files #3249

peterbe opened this issue Mar 15, 2021 · 1 comment · Fixed by #3250
Assignees
@peterbe

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 15, 2021

In fileCheck() we're only looking for the presence of a script tag inside the SVG. We should look for other on-handlers.
@peterbe peterbe self-assigned this Mar 15, 2021
peterbe added a commit to peterbe/yari that referenced this issue Mar 15, 2021
@peterbe
Check of unsafe HTML in SVG files
f94b1f6 
Fixes mdn#3249
@peterbe peterbe mentioned this issue Mar 15, 2021
Merged
escattone pushed a commit that referenced this issue Mar 15, 2021
@peterbe
Check of unsafe HTML in SVG files (#3250)
8556a9e 
* Check of unsafe HTML in SVG files

Fixes #3249

* mention in index.html file

* feedbacked
@peterbe
Copy link
Contributor Author

peterbe commented Mar 16, 2021

Excellent! mdn/content#3162 failed now. As expected.

@peterbe peterbe mentioned this issue Mar 16, 2021
Closed
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
@peterbe
Check of unsafe HTML in SVG files (mdn#3250)
918ea87 
* Check of unsafe HTML in SVG files

Fixes mdn#3249

* mention in index.html file

* feedbacked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check of unsafe HTML in SVG files peterbe/yari
1 participant
@peterbe