Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headings should have an underline when you hover over #3205

Closed
peterbe opened this issue Mar 11, 2021 · 0 comments · Fixed by #3289
Closed

headings should have an underline when you hover over #3205

peterbe opened this issue Mar 11, 2021 · 0 comments · Fixed by #3289
Assignees
@schalkneethling
Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases.

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 11, 2021

In Prod (which hasn't upgrade itself yet at the time of writing)
Screen Shot 2021-03-11 at 4 23 05 PM
Screen Shot 2021-03-11 at 4 23 36 PM

In main:
Screen Shot 2021-03-11 at 4 23 59 PM
Screen Shot 2021-03-11 at 4 24 16 PM

I suspect it happened because of #3171 which landed in main a couple of hours ago.
@schalkneethling schalkneethling added the p1 We will address this soon and will provide capacity from our team for it in the next few releases. label Mar 12, 2021
@peterbe peterbe mentioned this issue Mar 15, 2021
Merged
@schalkneethling schalkneethling mentioned this issue Mar 21, 2021
Merged
peterbe pushed a commit that referenced this issue Mar 22, 2021
fix: heading underline on hover and focus (#3289)
8e45ae1 
Add underline on hover and focus for linked headings

Fix #3205
peterbe pushed a commit to peterbe/yari that referenced this issue Jun 1, 2021
@peterbe
fix: heading underline on hover and focus (mdn#3289)
39cd87a 
Add underline on hover and focus for linked headings

Fix mdn#3205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schalkneethling schalkneethling

Labels
p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: heading underline on hover and focus
2 participants
@peterbe @schalkneethling