fix(glean): fix url metrics (#9516)

* fix(glean): fix url metrics * add base url for referrer
mdn · Aug 19, 2023 · f962258 · f962258
1 parent e9f49cd
commit f962258
Showing 1 changed file with 17 additions and 4 deletions.
diff --git a/client/src/telemetry/glean-context.tsx b/client/src/telemetry/glean-context.tsx
@@ -44,6 +44,17 @@ export type GleanAnalytics = {
 const FIRST_PARTY_DATA_OPT_OUT_COOKIE_NAME = "moz-1st-party-data-opt-out";
 const GLEAN_APP_ID = "mdn-yari";
 
+function urlOrNull(url?: string, base?: string | URL) {
+  if (!url) {
+    return null;
+  }
+  try {
+    return new URL(url, base);
+  } catch (_) {
+    return null;
+  }
+}
+
 function glean(): GleanAnalytics {
   if (typeof window === "undefined" || !GLEAN_ENABLED) {
     //SSR return noop.
@@ -74,11 +85,13 @@ function glean(): GleanAnalytics {
 
   const gleanContext = {
     page: (page: PageProps) => {
-      if (page.path) {
-        pageMetric.path.set(page.path);
+      const path = urlOrNull(page.path);
+      if (path) {
+        pageMetric.path.setUrl(path);
       }
-      if (page.referrer) {
-        pageMetric.referrer.set(page.referrer);
+      const referrer = urlOrNull(page.referrer, window?.location.href);
+      if (referrer) {
+        pageMetric.referrer.setUrl(referrer);
       }
       pageMetric.httpStatus.set(page.httpStatus);
       if (page.geo) {