Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove {{page}} macro from API docs #3913

Merged
merged 13 commits into from
Feb 21, 2022
Merged

Remove {{page}} macro from API docs #3913

merged 13 commits into from
Feb 21, 2022

Conversation

alattalatta
Copy link
Member

#3897

  • {{page}} 제거
  • Markdown (히스토리 없는 문서만)
    • 내용 수정 없습니다.

@alattalatta alattalatta requested a review from a team as a code owner January 30, 2022 12:59
@alattalatta alattalatta requested review from cos18 and removed request for a team January 30, 2022 12:59
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Jan 30, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 30, 2022

Preview URLs

Flaws

URL: /ko/docs/Web/API/FileReader/result
Title: FileReader.result
on GitHub
Flaw count: 1

  • macros:
    • /ko/docs/Web/API/ArrayBuffer does not exist

URL: /ko/docs/Web/API/Network_Information_API
Title: Network Information API
on GitHub
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/Window/navigator/connection does not exist
    • /ko/docs/Web/API/Window/navigator/connection does not exist
  • broken_links:
    • Can't resolve /en/Online_and_offline_events
  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)
  • bad_bcd_links:
    • no explanation!

URL: /ko/docs/Web/API/BatteryManager
Title: BatteryManager
on GitHub
Flaw count: 8

  • macros:
    • /ko/docs/Web/API/Window/navigator/battery does not exist
    • /ko/docs/Web/API/BatteryManager/level does not exist but fell back to /en-US/docs/Web/API/BatteryManager/level
    • /ko/docs/Web/API/BatteryManager/onchargingchange does not exist but fell back to /en-US/docs/Web/API/BatteryManager/chargingchange_event
    • /ko/docs/Web/API/BatteryManager/onchargingtimechange does not exist but fell back to /en-US/docs/Web/API/BatteryManager/chargingtimechange_event
    • /ko/docs/Web/API/BatteryManager/ondischargingtimechange does not exist but fell back to /en-US/docs/Web/API/BatteryManager/dischargingtimechange_event
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/WebAPI/Battery_Status

URL: /ko/docs/Web/API/Screen
Title: Screen
on GitHub
Flaw count: 15

  • macros:
    • /ko/docs/Web/API/Window/screen does not exist but fell back to /en-US/docs/Web/API/Window/screen
    • /ko/docs/Web/API/Screen/availTop does not exist but fell back to /en-US/docs/Web/API/Screen/availTop
    • /ko/docs/Web/API/Screen/availLeft does not exist but fell back to /en-US/docs/Web/API/Screen/availLeft
    • /ko/docs/Web/API/Screen/availHeight does not exist but fell back to /en-US/docs/Web/API/Screen/availHeight
    • /ko/docs/Web/API/Screen/availWidth does not exist but fell back to /en-US/docs/Web/API/Screen/availWidth
    • and 9 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /ko/docs/Web/API/Geolocation_API
Title: Geolocation API
on GitHub
Flaw count: 10

  • macros:
    • /ko/docs/Web/API/GeolocationPositionError does not exist but fell back to /en-US/docs/Web/API/GeolocationPositionError
    • /ko/docs/Web/API/PositionOptions redirects to /ko/docs/Web/API/Geolocation/getCurrentPosition
    • /ko/docs/Web/API/GeolocationCoordinates does not exist but fell back to /en-US/docs/Web/API/GeolocationCoordinates
    • /ko/docs/Web/API/GeolocationCoordinates does not exist but fell back to /en-US/docs/Web/API/GeolocationCoordinates
    • /ko/docs/Web/API/GeolocationPositionError does not exist but fell back to /en-US/docs/Web/API/GeolocationPositionError
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/WebAPI/Using_geolocation
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback

URL: /ko/docs/Web/API/Geolocation_API/Using_the_Geolocation_API
Title: Geolocation API 사용하기
on GitHub
Flaw count: 5

  • macros:
    • /ko/docs/Web/API/GeolocationCoordinates does not exist but fell back to /en-US/docs/Web/API/GeolocationCoordinates
    • /ko/docs/Web/API/DOMTimeStamp does not exist but fell back to /en-US/docs/Web/API/DOMTimeStamp
  • broken_links:
    • Can't resolve /ko/docs/Web/API/PositionOptions
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (0 in common of 4 possible)

URL: /ko/docs/Web/API/DragEvent
Title: DragEvent
on GitHub
Flaw count: 9

  • macros:
    • /ko/docs/Web/API/DragEvent/dataTransfer does not exist but fell back to /en-US/docs/Web/API/DragEvent/dataTransfer
    • /ko/docs/Web/API/DragEvent/DragEvent does not exist but fell back to /en-US/docs/Web/API/DragEvent/DragEvent
    • /ko/docs/Web/API/GlobalEventHandlers/ondrag does not exist but fell back to /en-US/docs/Web/API/GlobalEventHandlers/ondrag
    • /ko/docs/Web/API/GlobalEventHandlers/ondragend does not exist but fell back to /en-US/docs/Web/API/GlobalEventHandlers/ondragend
    • /ko/docs/Web/API/GlobalEventHandlers/ondragenter does not exist but fell back to /en-US/docs/Web/API/GlobalEventHandlers/ondragenter
    • and 4 more flaws omitted

URL: /ko/docs/Web/API/Notification/permission
Title: Notification.permission
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/WebAPI/Using_Web_Notifications

URL: /ko/docs/Web/API/Navigator/battery
Title: window.navigator.battery
on GitHub
Flaw count: 2

  • bad_bcd_queries:
    • No BCD data for query: api.Navigator.battery
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /ko/docs/Web/API/Document
Title: Document
on GitHub
Flaw count: 146

  • macros:
    • /ko/docs/Web/API/XMLDocument does not exist but fell back to /en-US/docs/Web/API/XMLDocument
    • /ko/docs/Web/API/Document/contentType does not exist but fell back to /en-US/docs/Web/API/Document/contentType
    • /ko/docs/Web/API/HTMLHtmlElement does not exist but fell back to /en-US/docs/Web/API/HTMLHtmlElement
    • /ko/docs/Web/API/Document/fonts does not exist but fell back to /en-US/docs/Web/API/Document/fonts
    • /ko/docs/Web/API/FontFaceSet does not exist but fell back to /en-US/docs/Web/API/FontFaceSet
    • and 115 more flaws omitted
  • broken_links:
    • Can't resolve /ko/docs/Web/API/Document_object_model/Using_the_W3C_DOM_Level_1_Core
    • Can't resolve https://developer.mozilla.org/ko/docs/Web/HTML/Element
    • Can't resolve /ko/docs/Web/XML/XML_introduction
    • Can't resolve https://developer.mozilla.org/en-US/docs/XPathExpression
    • Can't resolve https://developer.mozilla.org/ko/docs/Mozilla/Tech/XUL
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 15 more flaws omitted

URL: /ko/docs/Web/API/BiquadFilterNode
Title: BiquadFilterNode
on GitHub
Flaw count: 9

  • macros:
    • /ko/docs/Web/API/AudioContext/createBiquadFilter does not exist but fell back to /en-US/docs/Web/API/BaseAudioContext/createBiquadFilter
    • /ko/docs/Web/API/BiquadFilterNode/BiquadFilterNode does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode/BiquadFilterNode
    • /ko/docs/Web/API/BiquadFilterNode/frequency does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode/frequency
    • /ko/docs/Web/API/BiquadFilterNode/detune does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode/detune
    • /ko/docs/Web/API/BiquadFilterNode/Q does not exist but fell back to /en-US/docs/Web/API/BiquadFilterNode/Q
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /en-US/docs/Web_Audio_API/Using_Web_Audio_API

URL: /ko/docs/Web/API/DataTransfer/getData
Title: DataTransfer.getData()
on GitHub
Flaw count: 4

  • macros:
    • /ko/docs/Web/API/DataTransfer/setData does not exist but fell back to /en-US/docs/Web/API/DataTransfer/setData
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /ko/docs/Web/API/Notifications_API/Using_the_Notifications_API
Title: 알림 API 사용하기
on GitHub
Flaw count: 14

  • macros:
    • /ko/docs/Web/API/Notification/requestPermission does not exist but fell back to /en-US/docs/Web/API/Notification/requestPermission
    • /ko/docs/Web/API/Notification/requestPermission does not exist but fell back to /en-US/docs/Web/API/Notification/requestPermission
    • /ko/docs/Web/API/Notification/icon does not exist but fell back to /en-US/docs/Web/API/Notification/icon
    • /ko/docs/Web/API/Notification/body does not exist but fell back to /en-US/docs/Web/API/Notification/body
    • /ko/docs/Web/API/WindowTimers/setTimeout redirects to /ko/docs/Web/API/setTimeout
    • and 5 more flaws omitted
  • images:
    • External image URL
  • image_widths:
    • 'width' and 'height' set in 'style' attribute on <img> tag.
  • broken_links:
    • Can't resolve /ko/Apps/Build/User_notifications
  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)

External URLs

URL: /ko/docs/Web/API/FileReader/result
Title: FileReader.result
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Network_Information_API
Title: Network Information API
on GitHub


URL: /ko/docs/Web/API/BatteryManager
Title: BatteryManager
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Screen
Title: Screen
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Geolocation_API
Title: Geolocation API
on GitHub


URL: /ko/docs/Web/API/Geolocation_API/Using_the_Geolocation_API
Title: Geolocation API 사용하기
on GitHub

No new external URLs


URL: /ko/docs/Web/API/DragEvent
Title: DragEvent
on GitHub


URL: /ko/docs/Web/API/Notification/permission
Title: Notification.permission
on GitHub

No new external URLs


URL: /ko/docs/Web/API/Navigator/battery
Title: window.navigator.battery
on GitHub


URL: /ko/docs/Web/API/Document
Title: Document
on GitHub


URL: /ko/docs/Web/API/BiquadFilterNode
Title: BiquadFilterNode
on GitHub


URL: /ko/docs/Web/API/DataTransfer/getData
Title: DataTransfer.getData()
on GitHub


URL: /ko/docs/Web/API/Notifications_API/Using_the_Notifications_API
Title: 알림 API 사용하기
on GitHub

No new external URLs

(this comment was updated 2022-02-20 11:40:37.159411)

Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기여 감사드립니다. 리뷰드린 내용 확인 부탁드립니다!

files/ko/web/api/navigator/battery/index.html Show resolved Hide resolved

<p>Methods inherit from {{domxref("EventTarget")}}</p>

<p>{{page("/en-US/docs/Web/API/EventTarget","Methods")}}</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원본에서는 첫 문자가 대문자인 Page 매크로를 사용해서 내용을 보여주고 있는데 이 내용도 같이 지워야하는 매크로인가요?

https://github.com/mdn/content/blob/330026e2c4ce1ae92476d6a93f3bee425ddfcb0b/files/en-us/web/api/screen/index.md?plain=1#L60

Copy link
Member Author

@alattalatta alattalatta Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

매크로는 대소문자 구분을 하지 않습니다. {{Page}}{{page}} 모두 제거 대상입니다. 원문에 있는 것을 제거해야겠네요.

@alattalatta alattalatta requested a review from cos18 February 20, 2022 11:38
Copy link
Collaborator

@cos18 cos18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 수고하셨습니다!

@cos18 cos18 merged commit 201f558 into mdn:main Feb 21, 2022
@alattalatta alattalatta deleted the no-page-macro branch February 21, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants