[es, fr, ja, ko, pt-br, ru, zh-cn, zh-tw]: correct image file paths and demos paths #24765
Conversation
Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>
There was a problem hiding this comment.
Most of the changes look good, thank you!
I have not had the time to test on my local machine, but could you confirm that the EmbedLiveSample work after adding the titles (e.g. "Exemple_simple")? There is a reason why empty strings were used in these macros in translated-content.
|
Looks good for |
Thank you for the review! The EmbedLiveSample works correctly. I confirmed it on my local machine.
The display was not working as expected, so I fixed it in this pull request. I couldn't understand the reason why the macro was used with empty strings.My apologies. |
There was a problem hiding this comment.
The EmbedLiveSample works correctly. I confirmed it on my local machine.
Perfect, that should work then. We can confirm again once this is merged. Thanks very much for this @OHMORIYUSUKE !
In the past there were some strange issues with EmbedLiveSample in translated-content that required using empty strings, but it does seem that this is not a problem anymore (for the most part).
|
@nathipg |
|
You're not assigned as a reviewer, but if possible, could you kindly review it? Thank you in advance! |
|
Gently poking @mdn/yari-content-pt-br for a review :) |
|
I think there are so few I fixed the typo (made a suggestion). |
Thank you for reviewing Let's merge this once the typo is fixed (N.B. the same typo seems to be here as well) :) |
|
Hello to every one! It seems that the I don't know what do you think |
Yes, previously EmbedLiveSample behaved strangely and on translated-content we used empty strings in the macro, but this does not seem to be required anymore? I still have to catch up on some MDN updates so I may have missed it somewhere 😅 If the pt-br samples display well, then I think we can merge this now because it has been open for a long time. @leon-win maybe the typo that you found can be suggested/fixed in a separate PR (or an issue can be created) to avoid blocking this one? Happy to discuss more though! |
Sorry if I got in the way. I wanted to help)) |
No, not at all, thank you for seeing that typo! I was just thinking we could perhaps try another issue or PR so that the pt-br team can confirm it is correct without keeping this PR open. Would you like to create the issue/PR? If not I would be glad to do it 😃 I will merge since this most locales are approved, and thank you @leon-win and @Graywolf9 for checking the pt-br files! Thank you for your patience @OHMORIYUSUKE 🎉 |
I agree, it's better when each PR solves one specific problem. However, it doesn't always work out that way) I think it's better for you to do it)) 🤝 |
Description
Issue #24373 has been addressed.
Other image files had also been changed. For example,
starsolid.gifwas renamed tostar-solid.gif. Therefore, the file paths have been corrected.This problem occurs in the documentation for each language. All have been corrected in this Pull Request.
Motivation
If images and demos are not displayed correctly, they will confuse people referring to the document.
Additional details
Related issues and pull requests
Fixes #24373