Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zh-CN] init translate RTCIceCandidate.toJSON method #19684

Merged
merged 3 commits into from
Apr 24, 2024
Merged

[zh-CN] init translate RTCIceCandidate.toJSON method #19684

merged 3 commits into from
Apr 24, 2024

Conversation

ciyoe
Copy link
Contributor

@ciyoe ciyoe commented Apr 23, 2024

Description

Motivation

Additional details

Related issues and pull requests

@ciyoe ciyoe requested a review from a team as a code owner April 23, 2024 04:35
@ciyoe ciyoe requested review from yin1999 and removed request for a team April 23, 2024 04:35
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Apr 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Preview URLs

Flaws (6)

URL: /zh-CN/docs/Web/API/RTCIceCandidate/toJSON
Title: RTCIceCandidate：toJSON() 方法
Flaw count: 6

  • macros:
    • /zh-CN/docs/Web/API/RTCIceCandidate does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate
    • /zh-CN/docs/Web/API/RTCIceCandidate/candidate does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate/candidate
    • /zh-CN/docs/Web/API/RTCIceCandidate/sdpMid does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate/sdpMid
    • /zh-CN/docs/Web/API/RTCIceCandidate/sdpMLineIndex does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate/sdpMLineIndex
    • /zh-CN/docs/Web/API/RTCIceCandidate/usernameFragment does not exist but fell back to /en-US/docs/Web/API/RTCIceCandidate/usernameFragment
    • and 1 more flaws omitted

(comment last updated: 2024-04-24 13:11:37)

yin1999
yin1999 reviewed Apr 24, 2024
View reviewed changes
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
files/zh-cn/web/api/rtcicecandidate/tojson/index.md Outdated Show resolved Hide resolved
@ciyoe @yin1999
Apply suggestions from code review
52283da 
Co-authored-by: A1lo <yin199909@aliyun.com>
yin1999
yin1999 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ciyoe

@yin1999 yin1999 merged commit 5e05478 into mdn:main Apr 24, 2024
7 checks passed
@yin1999 yin1999 mentioned this pull request Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciyoe @yin1999