Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pre for CSSSyntax #175

Merged
merged 1 commit into from
Mar 15, 2021
Merged

remove pre for CSSSyntax #175

merged 1 commit into from
Mar 15, 2021

Conversation

fiji-flo
Copy link
Contributor

Depends on mdn/yari#3244

s/<pre.*>(\{\{csssyntax(\(.*\))?\}\})\n?</pre>/$1/g

@fiji-flo
remove pre for CSSSyntaxd
8f07bd5 
```
s/<pre.*>(\{\{csssyntax(\(.*\))?\}\})\n?</pre>/$1/g
```
@fiji-flo fiji-flo requested review from a team as code owners March 15, 2021 12:46
@fiji-flo fiji-flo mentioned this pull request Mar 15, 2021
Merged
chrisdavidmills
chrisdavidmills reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is because you'll be generating the <pre> inside the macro instead?

Looking at the en-US article source, the {{cssref}} calls look to be wrapped in <div> rather than <pre>....are you intending to remove those as well?

@fiji-flo
Copy link
Contributor Author

@chrisdavidmills yes the pre moves to kumascript mdn/yari#3244

As for the cssref (this is only addressing csssyntax), are they broken? We should to cleanup at some point I guess.

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills yes the pre moves to kumascript mdn/yari#3244

As for the cssref (this is only addressing csssyntax), are they broken? We should to cleanup at some point I guess.

Ack, sorry, I got confused. the {{csssyntax}} calls in the pages I looked at in the en-US locale are also inside <pre>, e.g. <pre class="brush: css">{{csssyntax}}</pre>

@fiji-flo fiji-flo merged commit 1bbb4d9 into mdn:main Mar 15, 2021
caugner pushed a commit to caugner/translated-content that referenced this pull request Aug 29, 2022
@fiji-flo
remove pre for CSSSyntaxd (mdn#175)
1ec101b 
```
s/<pre.*>(\{\{csssyntax(\(.*\))?\}\})\n?</pre>/$1/g
```
caugner pushed a commit to caugner/translated-content that referenced this pull request Aug 29, 2022
@fiji-flo
remove pre for CSSSyntaxd (mdn#175)
387a917 
```
s/<pre.*>(\{\{csssyntax(\(.*\))?\}\})\n?</pre>/$1/g
```
caugner pushed a commit to caugner/translated-content that referenced this pull request Aug 30, 2022
@fiji-flo
remove pre for CSSSyntaxd (mdn#175)
0d98436 
```
s/<pre.*>(\{\{csssyntax(\(.*\))?\}\})\n?</pre>/$1/g
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavidmills chrisdavidmills chrisdavidmills left review comments

@peterbe peterbe peterbe approved these changes

@escattone escattone Awaiting requested review from escattone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fiji-flo @chrisdavidmills @peterbe