Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-cn: init translation of svelte variables props #17363

Merged
merged 9 commits into from
Dec 13, 2023
Merged

zh-cn: init translation of svelte variables props #17363

merged 9 commits into from
Dec 13, 2023

Conversation

hanyujie2002
Copy link
Contributor

Description

Same as title

Motivation

Ditto

Additional details

None

Related issues and pull requests

Relates to #16965

@hanyujie2002 hanyujie2002 requested a review from a team as a code owner December 9, 2023 12:28
@hanyujie2002 hanyujie2002 requested review from jasonren0403 and removed request for a team December 9, 2023 12:28
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Dec 9, 2023
@hanyujie2002 hanyujie2002 mentioned this pull request Dec 9, 2023
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023 •
edited
Loading

Preview URLs

Flaws (21)

URL: /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_variables_props
Title: Svelte 中的动态行为：变量和属性
Flaw count: 21

  • macros:
    • /zh-CN/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Understanding_client-side_tools/Deployment
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_events_state
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_interactivity_filtering_conditional_rendering
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_accessibility
    • /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources does not exist but fell back to /en-US/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/React_resources
    • and 16 more flaws omitted
External URLs (3)

URL: /zh-CN/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_variables_props
Title: Svelte 中的动态行为：变量和属性

(comment last updated: 2023-12-13 13:47:34)

@hanyujie2002 @github-actions
Apply suggestions from code review
8490ff7 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hanyujie2002 @github-actions
Apply suggestions from code review
dd74280 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hanyujie2002 @github-actions
Apply suggestions from code review
ed4cfca 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jasonren0403
jasonren0403 requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions

...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
...cn/learn/tools_and_testing/client-side_javascript_frameworks/svelte_variables_props/index.md Outdated Show resolved Hide resolved
@hanyujie2002 @jasonren0403
Apply suggestions from code review
8694f67 
Co-authored-by: Jason Ren <40999116+jasonren0403@users.noreply.github.com>
jasonren0403
jasonren0403 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you @hanyujie2002 👍

@jasonren0403 jasonren0403 merged commit c9f6499 into mdn:main Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@jasonren0403 jasonren0403 jasonren0403 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanyujie2002 @jasonren0403